fix: extract_module missing import for macro calls#22437
Open
Albab-Hasan wants to merge 1 commit into
Open
Conversation
Fixes rust-lang#20209 was missing a arm, causing it to always return for macros. This made false, so the import was never added to the extracted module.
rustbot
added
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_def_in_mod_and_out_selhad arms for every item kind (Function,Adt,Const, etc.) but no arm forDefinition::Macro. it fell through to_ => {}and returned(false, false), makingdef_out_selalways false for macros. in downstream the condition(def_out_sel || !is_item) && use_stmt_not_in_selwas never satisfied so no import was added to the extracted module.add
Definition::Macro(x) => check_item!(x),to the match so the macros source location is checked the same way as other items.closes #20209