internal: Migrate generate_default_from_new assist to SyntaxEditor#21874
Open
Biruk-gebru wants to merge 1 commit intorust-lang:masterfrom
Open
internal: Migrate generate_default_from_new assist to SyntaxEditor#21874Biruk-gebru wants to merge 1 commit intorust-lang:masterfrom
generate_default_from_new assist to SyntaxEditor#21874Biruk-gebru wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Replace direct text insertion via `builder.insert()` with `SyntaxEditor`-based node insertion. Build the Default impl as a proper AST node using `make::impl_trait` instead of string concatenation with `format_to!`. Part of rust-lang#18285
Biruk-gebru
force-pushed
the
migrate-generate-default-from-new-to-syntax-editor
branch
from
3488a96 to
a6b2fe8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate
generate_default_from_newfrom direct text insertion viabuilder.insert()toSyntaxEditor-based node insertion.generate_trait_impl_text_from_impl()withmake::impl_trait()AST constructionbuilder.make_editor()+editor.insert_all(Position::after(...))for insertionPart of #18285