internal: Remove clone_for_update from flip_range_expr#21857
Draft
Amit5601 wants to merge 1 commit intorust-lang:masterfrom
Draft
internal: Remove clone_for_update from flip_range_expr#21857Amit5601 wants to merge 1 commit intorust-lang:masterfrom
Amit5601 wants to merge 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
ChayimFriedman2
approved these changes
Mar 23, 2026
Contributor
|
Thanks! |
Member
|
The original tree can be auto mutable and only supports replaces, not inserts crates/syntax/src/syntax_editor/edit_algo.rs:197 |
Amit5601
force-pushed
the
remove-clone-flip-range
branch
from
af37bd8 to
d5d9815
Compare
Member
|
This PR is wrong Unless you add features to |
rustbot
removed
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the use of
.clone_for_update()in theflip_range_exprassist. TheSyntaxEditorcan handle the insertion of the immutable nodes directly, so the mutable clones are no longer necessary.