fix: Add -Zjson-target-spec on Cargo calls where needed#21846
Draft
ChayimFriedman2 wants to merge 1 commit intorust-lang:masterfrom
Draft
fix: Add -Zjson-target-spec on Cargo calls where needed#21846ChayimFriedman2 wants to merge 1 commit intorust-lang:masterfrom
-Zjson-target-spec on Cargo calls where needed#21846ChayimFriedman2 wants to merge 1 commit intorust-lang:masterfrom
Conversation
Member
|
Yeah, the older versions without that flag will error with it. For the later, I guess we could just do it based on the toolchain version. Would that be hard because of some quirks in our codebase? (I can't check whether it's hard or not since I'm outside rn. Sry 😅 ) |
Member
|
We already have the sysroot here so we should have the toolchain version queried already somewhere |
Member
|
As Lukas said we should the toolchain version available there, I guess you could compare the toolchain version like the following lines: rust-analyzer/crates/project-model/src/cargo_config_file.rs Lines 171 to 173 in 803fb51 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #21821.
CC @ShoyuVanilla assuming you know - do we need to gate this only for affected Cargo versions? If so, how?