Revert "Turn BlockLoc into a tracked struct"
#21233
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
force-pushed
the
push-ursspxxkozkk
branch
from
890e16a to
c86f2b5
Compare
Contributor
|
I already encountered the panic quite a few times, happen when the angle brackets are unbalanced, because then the exprs get lowered as const params into the signature store. Quite annoying. So I'd say let's get this sooner than later. This may also need a beta backport. |
Member
|
I don't think it needs a backport, #21178 only landed on Tuesday 9th, while 1.93 branched on the 5th. |
Member
Author
|
ah sorry, didnt realize this didnt merge |
This reverts commit 64cabd8.
Veykril
force-pushed
the
push-ursspxxkozkk
branch
from
c86f2b5 to
0f26f67
Compare
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 64cabd8.