Fix complete unit return semicolon in arg-list #21032
Merged
+36
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
A4-Tacks
force-pushed
the
no-semicolon-in-arg-list
branch
from
8fdac80 to
b55c904
Compare
Example
---
```rust
fn foo() {}
fn baz(_: impl FnOnce()) {}
fn bar() {
baz(fo$0);
}
```
**Before this PR**
```rust
fn foo() {}
fn baz(_: impl FnOnce()) {}
fn bar() {
baz(foo();$0);
}
```
**After this PR**
```rust
fn foo() {}
fn baz(_: impl FnOnce()) {}
fn bar() {
baz(foo()$0);
}
```
A4-Tacks
force-pushed
the
no-semicolon-in-arg-list
branch
from
b55c904 to
7890856
Compare
Contributor
|
I want to review this PR, since I implemented the original logic and I remember I had few attempts to fix this, I want to make sure this PR is doing things correctly. |
Member
Author
Can you review this? |
ChayimFriedman2
approved these changes
Dec 16, 2025
Contributor
ChayimFriedman2
left a comment
ChayimFriedman2
left a comment
There was a problem hiding this comment.
Thought hard and couldn't find a way to break this, so, LGTM.
Thanks!
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20987
Example
Before this PR
After this PR