Add zoomable images feature#3127
Open
GuillaumeGomez wants to merge 4 commits into
Open
Conversation
Member
Author
|
Updated failing tests as well, ready for review. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2075.
The "zoomed-in" image looks like this:
The JS is only used to "zoom out" images with the "escape key", otherwise the feature works entirely without JS.
It works as follows: there is a (hidden) checkbox right before the image. The image itself is inside the label associated to the checkbox, meaning that when you click on the image, you switch the value of the checkbox. And thanks to
:checkedCSS selector, it changes the display of the zoomed out image.To make it obvious that you can "zoom in"/"zoom out" on an image, I changed the cursor to look like a loop using the CSS
cursor: zoom-in|zoom-outproperty.I also realized that images had the
altattribute, but not thetitleone, so I added it while I was at it.