Tier 3 more padding fixes #4922
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some were already done, more were missing
As previous commit, but tackle the *padding* fields
We have some leftovers of alignment data that is exposed
3v1n0
force-pushed
the
tier-3-more-padding-fixes
branch
from
fcaf794 to
eb3cf9a
Compare
JohnTitor
approved these changes
Jan 18, 2026
Member
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
Thanks! Approving based on #4859 (comment).
JohnTitor
added
the
stable-nominated
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Coming from #4859 by removing the main platforms that we cannot break
We have more fields that are padding areas that are currently marked as
public and not marked as Padding, which is causing the generated Hash
and PartialEq implementations to take care of them wrongly.
So fix them
Sources
Checklist
libc-test/semverhave been updated*LASTor*MAXareincluded (see #3131)
cd libc-test && cargo test --target mytarget);especially relevant for platforms that may not be checked in CI