-
Notifications
You must be signed in to change notification settings - Fork 1.2k
links old version of cf{g,s}et{i,o}speed for glibc #4882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
tgross35
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we aren't able to test the function pointers, would it be possible to add an integration test in https://github.com/rust-lang/libc/tree/main/libc-test/tests? Something simple to verify we link correctly and that our baud constants work.
It's unfortunate that we need as much cfg as we do here, but this fix is much needed. Thank you for putting this together!
tgross35
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(updating status)
|
Reminder, once the PR becomes ready for a review, use |
dd7a939 to
294e97c
Compare
This comment has been minimized.
This comment has been minimized.
44149d2 to
676fbe7
Compare
|
@rustbot ready |
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
tgross35
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Any particular reason you crossed this out? As I understand it, the issue should be resolved here. |
|
Hmm... |
|
Any chance you'd be able to attach a debugger and see what input caused the failure? |
|
Well... it seems simple version issue
(So if you cut 0.2.179, it will be solved |
|
I'm planning to do the release today or tomorrow, but your report spooked me a bit. Could you try by pushing a patch to your fork that sets the rev to 0.2.999 or so, then redoing the test? Cargo only picks up the patch table if the version is greater and semver-compatible. |
|
It seems nix 0.30.1's compile error. I think we can't keep semver-compatible at next release. uutils cannot use main branch of nix too. |
|
I'll ping you once I backport this then. I appreciate you taking the time to test this out.
For reference, |
|
uutils/coreutils does not use 0.2.178 currently: uutils/coreutils#8722 (comment) I 0.2.999 did not fix it. |
(backport <rust-lang#4882>) (cherry picked from commit b5c3653)
(backport <rust-lang#4882>) (cherry picked from commit b5c3653)
|
Backported this in #4906. A release is cooking |
Thanyou! |
Description
Fixes#4692.Sources
https://github.com/bminor/glibc
cfsetspeed
cfsetispeed
cfsetospeed
cfgetispeed
cfgetospeed
@rustbot label stable-nominated