Skip to content

chore: improve cargo maintenance path#17029

Open
vip892766gma wants to merge 1 commit into
rust-lang:masterfrom
vip892766gma:maint/20260524165708
Open

chore: improve cargo maintenance path#17029
vip892766gma wants to merge 1 commit into
rust-lang:masterfrom
vip892766gma:maint/20260524165708

Conversation

@vip892766gma
Copy link
Copy Markdown

Summary:

  • Add focused unit tests in crates/cargo-util/src/paths.rs covering edge cases of existing helpers like strip_prefix_canonical, normalize_path, and bytes2path (empty input, trailing separators, parent-traversal beyond root, non-UTF8 components on unix) to harden error branches without changing behavior.
  • Keep the change narrow so it is straightforward to review.

Notes:

  • I kept this scoped to the relevant implementation and tests.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 24, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented May 24, 2026

r? @weihanglo

rustbot has assigned @weihanglo.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @ehuss, @epage, @weihanglo
  • @ehuss, @epage, @weihanglo expanded to ehuss, epage, weihanglo
  • Random selection from ehuss, epage, weihanglo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants