Display and stop on installation error in perf search#431
Open
ehuss wants to merge 1 commit into
Open
Conversation
This changes the linear search done in the unrolled perf search so that it displays an error if it is unable to install a toolchain. Previously it would silently try each unrolled build in sequence. Additionally this stops the search if there is an install error. I think this is the correct behavior, because: - In most cases, if one install fails, all of them will fail. - If in a rare case where some succeed, but some fail, it would be incorrect to try any of the ones after the failure because it could incorrectly report the regression in a PR that just happens to land after a PR that failed to install but was the real culprit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the linear search done in the unrolled perf search so that it displays an error if it is unable to install a toolchain. Previously it would silently try each unrolled build in sequence.
Additionally this stops the search if there is an install error. I think this is the correct behavior, because: