Remove release date.#657
Open
reitermarkus wants to merge 1 commit intomainfrom
Open
Conversation
sgued
approved these changes
Apr 27, 2026
sgued
requested changes
Apr 27, 2026
Contributor
sgued
left a comment
sgued
left a comment
There was a problem hiding this comment.
Wait the release was not published to crates.io
Member
Author
|
Ah, sorry, I didn't realize we don't have a publishing workflow. |
reitermarkus
force-pushed
the
release-date
branch
from
236c4b9 to
53bf380
Compare
Member
Author
|
Okay, it is now published. Also removed the date here now since it doesn't really matter anyways when you can trivially find the commit. |
Contributor
|
If we remove the release date for 0.9.3 we should remove it for every release no ? |
Contributor
Fwiw, I agree. I also don't think there's anything wrong with removing a tag and then retagging. A tag represents a release and if it didn't really happen, the tag in question loses all its meaning. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maybe we should just remove the date, since this always requires the release PR to be up-to-date when merged.