Update remaining crates to edition 2021.#621
Open
wt wants to merge 1 commit intorust-embedded:masterfrom
Open
Conversation
wt
force-pushed
the
upgrade_to_edition_2021
branch
from
c7c2f57 to
ff1f7c7
Compare
Author
|
Looks like MSRV would need to be moved to 1.68 for this. Would that be acceptable? Why, you ask? |
wt
force-pushed
the
upgrade_to_edition_2021
branch
4 times, most recently
from
82f2868 to
c0c13ca
Compare
Author
|
There were some other issues that required 1.71 instead of 1.68. |
wt
force-pushed
the
upgrade_to_edition_2021
branch
from
c0c13ca to
53f07a1
Compare
wt
force-pushed
the
upgrade_to_edition_2021
branch
5 times, most recently
from
d1c5d99 to
967980e
Compare
xtask/Cargo.toml
Outdated
| [package] | ||
| name = "xtask" | ||
| version = "0.0.0" | ||
| version = "0.0.1" |
Contributor
There was a problem hiding this comment.
This is just tooling for the repo, so it can stay at 0.0.0
Author
There was a problem hiding this comment.
I backed out the version change.
Also, the version attribute is optional and defaults to 0.0.0. Should we just remove that line altogether?
wt
force-pushed
the
upgrade_to_edition_2021
branch
from
967980e to
5906a32
Compare
MSRV needs to move to 1.71 for this to work since there are deps that depend on that version.
wt
force-pushed
the
upgrade_to_edition_2021
branch
from
5906a32 to
3796cc3
Compare
adamgreig
approved these changes
Feb 15, 2026
Member
|
I don't think we strictly require a vote to update the MSRV, but I'll leave this open for a few days in case anyone wants to chime in or comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pushes the crates that are still listed as edition 2018 to 2021. I test built all of them.
@jonathanpallant adds:
I think we need input from the whole team for an MSRV bump. This PR moves us to 1.71.