Open
Conversation
thejpster
reviewed
Mar 27, 2026
src/iter.rs
Outdated
| let mem_start = self.base_address; | ||
| let mem_end = self.base_address + self.memory.len() as u32; | ||
| while let Some(region) = self.regions.next() { | ||
| for region in self.regions.by_ref() { |
Member
There was a problem hiding this comment.
Suggested change
| for region in self.regions.by_ref() { | |
| for region in self.regions.by_ref() { |
Formatting looks off?
Contributor
Author
There was a problem hiding this comment.
yes ,need to re-run cargo fmt
thejpster
reviewed
Mar 27, 2026
| return Err(NorFlashErrorKind::OutOfBounds); | ||
| } | ||
| if offset % align != 0 || length % align != 0 { | ||
| if !offset.is_multiple_of(align) || !length.is_multiple_of(align) { |
Contributor
Author
There was a problem hiding this comment.
requires rust MSRV 1.87 though. Do you think the MSRV bump is okay for this PR as well?
Member
There was a problem hiding this comment.
I'm fine with it, but I'm not the primary maintainer here. Thoughts @diondokter ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.