Refactoring env var case convert to convert each segment between separator#746
Open
11alieberman wants to merge 1 commit intorust-cli:mainfrom
Open
Refactoring env var case convert to convert each segment between separator#74611alieberman wants to merge 1 commit intorust-cli:mainfrom
11alieberman wants to merge 1 commit intorust-cli:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it looks like when you are parsing the environment variables into the config and you have some key with multiple segments separated by the ., (key1.key2.key3) when you do the case convert for a case like Pascal, it will result in (Key1.key2.key3). I am not sure if this is intended, because I would think the result should be (Key1.Key2.Key3), where each segment is individually case converted.
This PR aims to refactor the case conversion to convert each segment and not just the first segment.
Also aims to address #693