Open
Conversation
Add an integration test `signer__wallet_display_address` to verify the functionality of the `walletdisplayaddress` RPC call when using an external signer. The test mocks a Hardware Wallet (HWW) interaction by: 1. Creating a temporary shell script that acts as an external signer. 2. Handling the 'enumerate', 'getdescriptors', and 'displayaddress' commands expected by Bitcoin Core. 3. Spawning a node with the `-signer` argument pointing to this mock. 4. Creating a descriptor-based wallet with `external_signer` enabled. 5. Asserting that calling `wallet_display_address` returns the expected address from the mock signer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
signer__wallet_display_addresstestswalletdisplayaddressRPC call mocking an external signer.The test mocks a Hardware Wallet (HWW) interaction by:
-signerargument pointing to this mock.external_signerenabled.wallet_display_addressreturns the expected address from the mock signer.Heavily Inspired by wallet_signer.py