Skip to content

Release tracking PR: bitreq 0.3.4#508

Open
tcharding wants to merge 1 commit intorust-bitcoin:masterfrom
tcharding:push-tnxtpmkoovps
Open

Release tracking PR: bitreq 0.3.4#508
tcharding wants to merge 1 commit intorust-bitcoin:masterfrom
tcharding:push-tnxtpmkoovps

Conversation

@tcharding
Copy link
Member

I released bitreq 0.3.3 without first merging PR #500 which was the whole point of the release - face palm.

v0.3.3 has been yanked.

Changelog is correct already. Bump the version and update the lock files.

@tcharding
Copy link
Member Author

tcharding commented Feb 16, 2026

I'm going to merge this without any acks. Its a 3 line diff that bumps the version and updates the lock files.

@TheBlueMatt and/or @tnull please post merge ack this. The fail was all mine.

@tcharding
Copy link
Member Author

Not sure if I should leave the 0.3.3 tag in place or delete it too since 0.3.3 has been yanked?

@tcharding
Copy link
Member Author

ooph, I need an approve othewise I'd have to change the repo settings, don't want to to do that ...

@tcharding tcharding changed the title bitreq: Bump version to 0.3.4 Release tracking PR: bitreq 0.3.4 Feb 16, 2026
tnull
tnull previously approved these changes Feb 16, 2026
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 11cc75b

@TheBlueMatt
Copy link
Member

Do you want to also include #504?

TheBlueMatt
TheBlueMatt previously approved these changes Feb 16, 2026
Copy link
Member

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 11cc75b after #504 is merged.

I released `bitreq 0.3.3` without first merging PR rust-bitcoin#500 which was the
whole point of the release - face palm.

`v0.3.3` has been yanked.

Changelog is correct already. Bump the version and update the lock files.
@tcharding tcharding dismissed stale reviews from TheBlueMatt and tnull via 63f4ed6 February 16, 2026 20:29
@tcharding
Copy link
Member Author

I had to force push fixing merge conflicts to the manifest because of #504. Needs re-ack from someone please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants