WIP: Create an async corepc-client (adding jsonrpc support into the corepc-client crate)#506
Draft
jamillambert wants to merge 6 commits intorust-bitcoin:masterfrom
Draft
Conversation
Move the required parts of jsonrpc into corepc-client so that it does not depend on jsonrpc. The intention is to extend it to work with an async client later.
Create a new folder for the upcoming async client and copy in the existing client_sync code. Code copy only except for the renaming to async to make the next patch easier to review.
Edit the copy of the sync client created in the previous commit to be async. Update the readme and cargo.toml files. Add only small set of RPCs.
Add some vibe coded tests for the async client to check that everything is functional. Tests are for development purposes only to catch simple errors like feature gates etc. and have not been reviewed.
jamillambert
force-pushed
the
0212-WIP-client-async-jsonrpc-move
branch
from
77bedf8 to
b816dbc
Compare
Member
|
#505 is a better approach IMO. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not a merge candidate. Proof of concept only.
This is PR option 2 of 2, both add an async corepc-client but in a slightly different ways. This version adds the required part of
jsonrpcintocorepc-clientthe other version adds async support to jsonrpc (#505).The patches are structured to make it easier to see what was changed from sync to async. First the sync version is copied and renamed, then in a separate patch it is changed to async.
The jsonrpc part that was added to corepc-client could instead be a separate crate, or if the rest of jsonrpc is not required it could be the replacement for it.