CloseAccount spec corrections (non-multisig)
#149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dition These assertions are checking the effects of `close_unchecked` which calls a syscall `sol_memset_`. Currently our target is not `solana` so we are not compiling these syscalls calls, nor their bodies.
dkcumming
added a commit
that referenced
this pull request
Jan 21, 2026
Adds guard on postcondition check for `owner`, `lamports`, and `data_len` behind a feature flag, specifically `target_os = "solana"` and `target_arch = "bpf"`. This means that `CloseAccount` now passes for non-multisig. However this proof passing is slightly limited in strength since it does not check that the `data`, `lamports`, and `owner` field are zeroed when `close_unchecked` is called in the implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds guard on postcondition check for
owner,lamports, anddata_lenbehind a feature flag, specificallytarget_os = "solana"andtarget_arch = "bpf". This means thatCloseAccountnow passes for non-multisig.However this proof passing is slightly limited in strength since it does not check that the
data,lamports, andownerfield are zeroed whenclose_uncheckedis called in the implementation.