Implement coverage feedback loop#84
Open
tothtamas28 wants to merge 3 commits into
Open
Conversation
31 tasks
tothtamas28
force-pushed
the
coverage-loop
branch
2 times, most recently
from
5f02d61 to
8a40447
Compare
gtrepta
approved these changes
May 20, 2026
Contributor
gtrepta
left a comment
gtrepta
left a comment
There was a problem hiding this comment.
LGTM. Nice utilities for getting info out of the config!
Have you ran this with the 9lives contract? I'm running the test_end_to_end_intense function and I see it finding lots of "Objectives" which would be non-zero exit codes, and the coverage isn't changing too much, so I'm not sure if I'm building the contract and the spec correctly.
Comment on lines
+138
to
+142
| pub fn kllvm_kore_block_dump_hotfix(s: &str) -> &str { | ||
| // TODO This is a hotfix for a bug in kore_block_dump | ||
| let terminator = r#"Lbl'-LT-'generatedCounter'-GT-'{}(\dv{SortInt{}}("0")))"#; | ||
| let pos = s.find(terminator).expect("terminator not found"); | ||
| &s[..pos + terminator.len()] |
Contributor
There was a problem hiding this comment.
Hm, are there some garbage bytes showing up after this terminator? I think I remember observing this while I was dealing with the latin-1 decoding issue we had, but I assumed this was a part of that issue.
tothtamas28
force-pushed
the
coverage-loop
branch
from
8a40447 to
0f7c1b2
Compare
tothtamas28
force-pushed
the
coverage-loop
branch
from
c39a4bc to
ac578d4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires up a real coverage feedback loop by parsing KORE output into a
kore::Patterntree and extracting data from the<coverage>cell, replacing the previous stub.Changes
get_exit_codeandwrite_coverage_datanow take&kore::Patterninstead of&kllvm::Block, dropping the regex-based string scraping.get_coverage_sizeis derived from actual coverage instead of a hardcoded100.kllvm_kore_block_dump_hotfixto trim raw dump output at the<generatedCounter>terminator, working around an upstream bug.<coverage>cell no longer has extreme nesting depth.