Conversation
tothtamas28
reviewed
Feb 19, 2026
tothtamas28
approved these changes
Feb 19, 2026
| .PHONY: check-clippy | ||
| check-clippy: | ||
| cargo clippy -- --deny warnings | ||
| cargo clippy --tests -- --deny warnings |
Collaborator
There was a problem hiding this comment.
Doesn't this already check everything
cargo clippy -- --deny warnings
does?
Contributor
Author
There was a problem hiding this comment.
That isn't what I observe. Adding a syntax error somewhere under kframework/tests doesn't get caught by it, but with --tests, it does.
Collaborator
There was a problem hiding this comment.
I mean
cargo clippy --tests -- --deny warnings
might check strictly more than
cargo clippy -- --deny warnings
in which case you can drop the command without the --tests.
Contributor
Author
There was a problem hiding this comment.
Oh, sorry. Hm, I'm not sure. A quick search revealed --all-targets, which gets touted as best practice for CI pipelines. So, I've changed it to that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the root of the repository a cargo workspace instead of a package. This helps to make managing multiple crates easier.
The kframework package that was in the root is moved to "kframework_core", where we can keep a standalone library of K functionality (parsing, data structures, matching, rewriting, etc.)