Open
Conversation
|
New plugin |
|
Feedback:
A new scan will be automatically performed on the next push to the PR branch. Internal use only: Reviewer details Maintainer details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My plugin is heavily based on Odablock sounds, but instead I've changed sounds for Carl Johnson of GTA: San Andreas. All it does it add or change some sounds, such as accepting/declining trades, shooing stray dogs, or getting hit.
I didn't see if mature language/cussing was against ToS in any of the documentation, but if that's the case, I can easily swap the offending sounds out for one that doesn't have swearing in it, God knows I have plenty to choose from.
Thank you for considering my plugin and I hope everything's all tidy and clean and ready to go.