Skip to content

Create sounds-of-san-andreas#11241

Open
donusgits wants to merge 1 commit intorunelite:masterfrom
donusgits:sosa
Open

Create sounds-of-san-andreas#11241
donusgits wants to merge 1 commit intorunelite:masterfrom
donusgits:sosa

Conversation

@donusgits
Copy link
Copy Markdown

My plugin is heavily based on Odablock sounds, but instead I've changed sounds for Carl Johnson of GTA: San Andreas. All it does it add or change some sounds, such as accepting/declining trades, shooing stray dogs, or getting hit.

I didn't see if mature language/cussing was against ToS in any of the documentation, but if that's the case, I can easily swap the offending sounds out for one that doesn't have swearing in it, God knows I have plenty to choose from.

Thank you for considering my plugin and I hope everything's all tidy and clean and ready to go.

@runelite-github-app
Copy link
Copy Markdown

@runelite-github-app
Copy link
Copy Markdown

Feedback:

  • Use of javax.sound.sampled.LineUnavailableException is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead
  • Use of javax.sound.sampled.UnsupportedAudioFileException is not allowed: Use of javax.sound, use net.runelite.client.audio.AudioPlayer instead

A new scan will be automatically performed on the next push to the PR branch.


Internal use only: Reviewer details Maintainer details

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant