Skip to content

Update music-track-display#11211

Open
Tommynaut wants to merge 6 commits intorunelite:masterfrom
Tommynaut:Tommynaut-patch-1
Open

Update music-track-display#11211
Tommynaut wants to merge 6 commits intorunelite:masterfrom
Tommynaut:Tommynaut-patch-1

Conversation

@Tommynaut
Copy link
Copy Markdown
Contributor

Patch to allow plugin to work with recent changes to music player.

Fixed an issue with the plugin field for the runelite-plugin.properties file.
Updated files to disable the currently-unused config
@runelite-github-app
Copy link
Copy Markdown

runelite-github-app bot commented Mar 25, 2026

@runelite-github-app
Copy link
Copy Markdown

runelite-github-app bot commented Mar 25, 2026

Internal use only: Reviewer details Maintainer details

@iProdigy
Copy link
Copy Markdown
Member

could you remove if(provideConfig(configManager).displayToggle() == DisplayMode.Overlay) from ShowMusicPlugin#shutDown so overlayManager.remove(overlay); is always called?

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Mar 26, 2026
@runelite-github-app runelite-github-app bot added size-xs and removed waiting for author waiting for the pr author to make changes or respond to questions labels Mar 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants