Update faux-bingo plugin #10250
Merged
Update faux-bingo plugin #10250
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding loot logging capabilities to the plugin
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Individual events now queue their webhooks, and they are bundled after a short delay to avoid sending multiple messages to the same webhook from a single event.
Member
|
You cannot add new on-by-default network requests to a 3rd-party unverified service in a plugin that does not already have them.
(input-by-user discord webhook URLs do not require this disclaimer which is why it didn't come up before) |
riktenx
added
the
waiting for author
runelite-github-app
bot
removed
the
waiting for author
Contributor
Author
Understood! Made the requested change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding loot logging capabilities to the plugin, with config section added and the ability to toggle. Sends raw loot information to an external api for data collection to enable post event summary data around overall loot gained for different teams and other stats around drops, pets, etc.
Also added was queue logic to all events to avoid a single item / event from sending multiple webhooks. Events are grouped by item name before being sent after a short delay.