Skip to content

Conversation

@Deagsly
Copy link

@Deagsly Deagsly commented Jan 18, 2026

No description provided.

@runelite-github-app
Copy link

runelite-github-app bot commented Jan 18, 2026

@Deagsly
Copy link
Author

Deagsly commented Jan 18, 2026

made public, just plays sounds when killing blobs in inferno because my mate hates them

@Deagsly
Copy link
Author

Deagsly commented Jan 18, 2026

retry

3 similar comments
@Deagsly
Copy link
Author

Deagsly commented Jan 18, 2026

retry

@Deagsly
Copy link
Author

Deagsly commented Jan 18, 2026

retry

@Deagsly
Copy link
Author

Deagsly commented Jan 18, 2026

retry

@pajlada
Copy link
Contributor

pajlada commented Jan 18, 2026

use runelite's client AudioPlayer API1 if you can. the build fails atm because you're trying to use a new dependency for playing your sound.

if runelite's AudioPlayer API doesn't work for you, you can use Jaraco (see other plugins as examples)

@pajlada
Copy link
Contributor

pajlada commented Jan 18, 2026

Hi again, please read through https://github.com/runelite/plugin-hub#third-party-dependencies if you're looking to use a third party dependency we don't already support.
I want to highlight the last sentence of the paragraph, and highly suggest you look at my previous message for another option.
Feel free to ask here if you have any questions!

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 18, 2026
@Deagsly
Copy link
Author

Deagsly commented Jan 19, 2026

Hi again, please read through runelite/plugin-hub#third-party-dependencies if you're looking to use a third party dependency we don't already support. I want to highlight the last sentence of the paragraph, and highly suggest you look at my previous message for another option. Feel free to ask here if you have any questions!

Appreciate the helpful response mate, working to resolve.

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jan 19, 2026
@Felanbird Felanbird added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 19, 2026
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jan 19, 2026
@runelite-github-app
Copy link

runelite-github-app bot commented Jan 19, 2026

Internal use only: Reviewer details Maintainer details

@iProdigy
Copy link
Member

Could you cite where you obtained each of the wav's in the resources folder? We cannot package copyrighted material in the plugin jar (without permission from the owner of the work)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants