Skip to content

Conversation

@DarockObama
Copy link
Contributor

@DarockObama DarockObama commented Jan 14, 2026

A notifier meant for streaming.

Note: After long consideration and consulting with the Dink Plugin developers, it seemed most logical to let this be its own plugin. This will allow for upcoming features that are nice for streaming purposes, but don't fit in Dink.

Since this plugin simply takes in data from Dink's outbound PluginMessage, it is relatively simple. Any feedback and suggestions for the source code is much appreciated, since this my first java project.

@runelite-github-app
Copy link

runelite-github-app bot commented Jan 14, 2026

@DarockObama DarockObama reopened this Jan 14, 2026
@runelite-github-app
Copy link

runelite-github-app bot commented Jan 14, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@iProdigy
Copy link
Member

In TriggerHandler could you please switch your okhttp call to use enqueue instead of execute to avoid blocking the client thread

@iProdigy iProdigy added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 14, 2026
@DarockObama
Copy link
Contributor Author

@iProdigy Fixed it! Let me know if the new TriggerHandler is ok and if there's anything else that needs fixing.
https://github.com/DarockObama/StreamerbotPlugin/blob/master/src/main/java/streamerbot/messaging/TriggerHandler.java

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jan 14, 2026
Fixed typo in DinkAmascutNotificationData and logger in TriggerHandler
@DarockObama
Copy link
Contributor Author

@iProdigy Thanks for noticing! Fixed it.

@iProdigy iProdigy merged commit e6b5549 into runelite:master Jan 20, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants