-
Notifications
You must be signed in to change notification settings - Fork 1.7k
update pvp-leaderboard #10184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
update pvp-leaderboard #10184
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
again we don't really let people do highlighting/tagging/overlays on random players because it's abusable for scouting, i don't want to have a discussion about this over this PR, come ask in the discord if you really want to argue for this if it becomes the consensus of at least more than one tenured maintainer (probably blue names) that it's okay, then i'm fine merging it |
5e21b7c to
10fc1fc
Compare
|
Players that have the plugin are now able to see other players that have the plugin ranks over their head by default. This is done via heartbeats that happen every 5mins to an api. Caching is added for these players and they will fall off after 2 hours (limiting backend calls for lots of players clumped together for things like tournaments for my backend). Data is grabbed from the website for the list of players. |
10fc1fc to
42574cc
Compare
42574cc to
7edaf51
Compare
|
Added in some additional bug fixes for DMM to have it work as intended for the seasonal. |
Rank displays when you right click -> PvP lookup on another player so you don't have to lookup players again and again. Options in the settings were added so you can choose how long this lasts above players heads.
Made it default for the rank to disappear after 15 minutes, can be toggled 1-360 minutes or turned off. This is reset when someone does another lookup, or if you engage in combat.