Skip to content

Conversation

@findarian
Copy link
Contributor

Rank displays when you right click -> PvP lookup on another player so you don't have to lookup players again and again. Options in the settings were added so you can choose how long this lasts above players heads.
Made it default for the rank to disappear after 15 minutes, can be toggled 1-360 minutes or turned off. This is reset when someone does another lookup, or if you engage in combat.

@runelite-github-app
Copy link

runelite-github-app bot commented Jan 13, 2026

@runelite-github-app
Copy link

runelite-github-app bot commented Jan 13, 2026

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@findarian findarian closed this Jan 14, 2026
@findarian findarian reopened this Jan 14, 2026
@riktenx
Copy link
Member

riktenx commented Jan 15, 2026

again we don't really let people do highlighting/tagging/overlays on random players because it's abusable for scouting, i don't want to have a discussion about this over this PR, come ask in the discord if you really want to argue for this

if it becomes the consensus of at least more than one tenured maintainer (probably blue names) that it's okay, then i'm fine merging it

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jan 15, 2026
@findarian findarian force-pushed the update-pvp-leaderboard branch from 5e21b7c to 10fc1fc Compare January 21, 2026 04:42
@runelite-github-app runelite-github-app bot added size-l and removed waiting for author waiting for the pr author to make changes or respond to questions size-m labels Jan 21, 2026
@findarian
Copy link
Contributor Author

Players that have the plugin are now able to see other players that have the plugin ranks over their head by default. This is done via heartbeats that happen every 5mins to an api. Caching is added for these players and they will fall off after 2 hours (limiting backend calls for lots of players clumped together for things like tournaments for my backend). Data is grabbed from the website for the list of players.

@findarian findarian force-pushed the update-pvp-leaderboard branch from 10fc1fc to 42574cc Compare January 21, 2026 10:16
@findarian findarian force-pushed the update-pvp-leaderboard branch from 42574cc to 7edaf51 Compare January 22, 2026 01:00
@findarian
Copy link
Contributor Author

Added in some additional bug fixes for DMM to have it work as intended for the seasonal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants