Unique npc kc tracker

[PuddingPants]

Request to have Unique NPC KC Tracker added to the plugin hub. Name was updated to only be lower case and use "-" instead of "_" or " ".

Plugin creates and assigns a unique ID based on NPC ID & death location (or unique location if a duplicate unique ID would be created). Entities assigned a unique ID can be hidden, tagged, or have menu entries changed via config.

[runelite-github-app]

New plugin unique-npc-kc-tracker: https://github.com/PuddingPants/unique-npc-killtracker/tree/bb889162a4d913246d84cfc45034d0e622cefffd

[tylerwgrass]

you don't need to close a reopen prs to address feedback, just push your changes to the existing pr

[PuddingPants]

Apologies, I am pretty new to this, and when I went to try and rename things it seemed to close the PR.

[riktenx]

IDK what your LLM did but it completely defiled your build.gradle, it should look exactly like the one from the template, fix that please

[PuddingPants]

Pardon my ignorance, but are the deprecated APIs the reason the build is failing? I updated the code on my end to Inject rather than create the Gson, but I want to make sure I correct everything before I push a new commit to this PR.

If the issue is stemming from something else can someone please help explain what needs to be changed.

[coopermor]

package failed
net.runelite.pluginhub.packager.PluginBuildException: unique-npc-kc-tracker: plugin uses terminally deprecated APIs:
Do not create fresh Gson instances, always @Inject the client's Gson.
You can customize it by calling .newBuilder() on it
	at net.runelite.pluginhub.packager.PluginBuildException.of(PluginBuildException.java:54)
	at net.runelite.pluginhub.packager.Plugin.assembleDisplayData(Plugin.java:771)
	at net.runelite.pluginhub.packager.Plugin.build(Plugin.java:550)
	at net.runelite.pluginhub.packager.Packager.buildPlugin(Packager.java:215)
	at net.runelite.pluginhub.packager.Packager.lambda$buildPlugins$0(Packager.java:155)
	at java.base/java.lang.Thread.run(Thread.java:829)


unique-npc-kc-tracker: plugin uses terminally deprecated APIs:
Do not create fresh Gson instances, always @Inject the client's Gson.
You can customize it by calling .newBuilder() on it

[runelite-github-app]

Internal use only: Reviewer details Maintainer details

[riktenx]

this is not allowed

https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features

ID based plugins: Plugins that use player provided IDs for the entirety of their functionality can cause moderation issues and outcomes that break Jagex's plugin rules. Due to this fact we will not be accepting any new ID based plugins. Plugins that use a specific set of IDs but do not allow user input will still be accepted. (e.g. plugins like Vardorvis Projectiles which only allows you to change a specific projectile to a set list of projectiles.)

[PuddingPants]

To make sure I'm understanding correctly. Is the whole plugin not going to be allowed or just the piece below?

@configitem(
keyName = "npcMatchRadiusOverrides",
name = "NPC Match Radius Overrides",
description = "Override match radius per NPC ID. Format: npcId=radius,npcId=radius"
)
default String npcMatchRadiusOverrides()
{
return "";
}
}

Main reason I put this in the config was so that NPCs like imps that wander far would be reassigned a unique ID on client restart. If I make specific NPC match radius for imps fixed and delete everything above would this be allowed?