-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add Hiscore's Tracker #10139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Hiscore's Tracker #10139
Conversation
Fix format to properties file
|
I'm not sure what your plan is with this plugin but it looks like it only takes a snapshot of stats/kills and displays it in the side panel. Which the XP tracker plugin already does. And WOM has remote tracking for more historical contexts. If you are planning to save xp/kills in config, we also aren't going to allow that as it will just balloon the config very fast. |
|
I'd suggest you use wom and create a group for your friends |
I've done that, wise old man is extremely clunky which is why I took the time to try this approach. A resource pack is just a reskin and they are allowed with no real purpose other than novelty, why would this not be? It breaks no rules, its a way to display information. I can create a separate JSON file for storage and reduce retention time? |
|
What are you talking about |
I'm talking about your comment that implies the plugin is redundant. A resource pack is a reskin and thats as redundant as you might find this plugin. Other than that it seems like the only real problem you had with the plugin besides your opinion of it was ballooning the config file with the retained data over time, so I proposed a way to mitigate that in an attempt to try and figure this out and still be able to use my plugin while conforming to your rules. Does that make sense? |
|
The biggest problem I had when I first looked at the plugin is it was just a highscores viewer that also stored the data in config. I'm just giving you an alternative that has extensive development and a proven track record that does what you already submitted. You said WOM is clunky but you haven't said why. Have you tried asking for help in their discord? |
I personally preferred to not have to be in a separate tab to see the hiscores/information, its clunky in the sense I would prefer to see the stats displayed in the sidepanel. I honestly like the current hiscores but I wanted to tweak it a bit to suit my preferences. I'm a nerd and I love numbers and seeing stats so I spent entirely too much time scheming up this plugin. I know to most it's probably stupid but I like it. I really do appreciate the feedback, I've been learning alot with this project. Other than your valid arguments for WOM, do you think if I store the data in a separate JSON instead of the config file (similar to loot tracker plugin) it would be allowed? I could even reduce the data retention period drastically. |
Yes |
|
Hi @raiyni, I've updated the plugin to use JSON file storage instead of config storage as you suggested. The changes are now in my repository's main branch (commits from Jan 11). Could you please re-run the CI checks so they test against the updated code? The current failed build is from Jan 10 before I implemented the JSON storage solution. Thank you! |
|
you need to update*** the commit hash in the marker file here |
|
New plugin |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
Is there anything I need to do to fix anything on my end? I'm new so I apologize for the questions. Thank you in advance for your time. |
|
no, if the build check passes it's ready for review |
|
do not write files outside of the base runelite directory. You're doing it in some places but not others. You can build a subdirectory w/ RUNELITE_DIR - https://static.runelite.net/runelite-client/apidocs/net/runelite/client/RuneLite.html#RUNELITE_DIR |
|
Thanks for the feedback! I've updated file path handling to use |
|
#10139 (comment) (again) |
Updated commit hash to include file path handling fixes. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
|
Hey I really appreciate your feedback. Thank you. I will continue to work on it |


Plugin Description
Complete hiscores-style tracker for OSRS players featuring:
Repository
https://github.com/RobertoChavez2433/hiscores-tracker
Author
RobertoChavez2433