Add Motivation plugin #10128
Merged
Add Motivation plugin #10128
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New plugin |
|
Internal use only: Reviewer details Maintainer details |
Member
|
do not sleep() or interrupt() the shared executor |
riktenx
added
the
waiting for author
Contributor
Author
|
Updated the plugin with the following changes:
Let me know if any other changes are needed. |
runelite-github-app
bot
removed
the
waiting for author
Member
|
you need to update the commit hash in your marker file here for me to see your changes |
riktenx
added
the
waiting for author
runelite-github-app
bot
removed
the
waiting for author
Changes in motivation plugin: - Rename plugin to Help Motivation - Improve sidebar UI with column headers, alternating row colors, hover effects - Use RuneScape fonts and orange color for rank values - Fix executor usage (replace Thread.sleep with executor.schedule) - Update gitignore
Zazarothh
force-pushed
the
add-motivation-plugin
branch
from
58635ff to
4ea0be3
Compare
Contributor
Author
|
My apologies, learning a lot doing this. Reviewed all the docs possible for this and still messing up. Thank you for what you do |
Member
|
when you get a review that asks you to change something you should really only change that and not also add and remove 500 random other lines of code 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Motivation plugin.
Features: