Skip to content

Conversation

@rdimaio
Copy link
Contributor

@rdimaio rdimaio commented Dec 17, 2024

No description provided.

@rdimaio
Copy link
Contributor Author

rdimaio commented Dec 20, 2024

Works now, but it doesn't automatically pick up the configuration from the config file. There's currently no way to pass this file to the action, so we have 3 options:

  1. pass the options from the config file into the GH actions as arguments (downside to this: we need to manually keep the config and the GH action workflow in sync)
  2. use pre-commit.ci (probably the most convenient solution, but not sure if we want to rely on an external framework for this)
  3. wait for the 'pass configuration' feature to be merged into the GH action. There was a PR from a few years ago but it wasn't merged due to some conflicts. I've picked it up here Add the config file option and tests codespell-project/actions-codespell#80

@rdimaio
Copy link
Contributor Author

rdimaio commented Feb 17, 2025

PR to their repository still pending. I guess we could alternatively use pre-commit.ci in the docs repo as well and we'd bypass the need for this.

@voetberg
Copy link
Contributor

voetberg commented Dec 4, 2025

PR to their repository still pending. I guess we could alternatively use pre-commit.ci in the docs repo as well and we'd bypass the need for this.

Would we like to instead push forward towards using a precommit? I think that is most practical at this stage (looking at the age of this PR)

@rdimaio
Copy link
Contributor Author

rdimaio commented Dec 14, 2025

codespell-project/actions-codespell#80 was merged last month

@rdimaio
Copy link
Contributor Author

rdimaio commented Dec 14, 2025

PR to their repository still pending. I guess we could alternatively use pre-commit.ci in the docs repo as well and we'd bypass the need for this.

Would we like to instead push forward towards using a precommit? I think that is most practical at this stage (looking at the age of this PR)

I agree and I think that would be in line with possibly adding precommit ci to the other rucio repos too. Closing this PR

@rdimaio rdimaio closed this Dec 14, 2025
@rdimaio rdimaio deleted the spellcheck-ci branch December 14, 2025 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants