-
Notifications
You must be signed in to change notification settings - Fork 165
implement homework 1 #774
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
implement homework 1 #774
Conversation
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| print "#{x}#{array[i - 1]} " | ||
| array[i] = array[i - 1] + array[i] | ||
| end | ||
| z-=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surrounding space missing for operator -=.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| end | ||
| print "#{x}#{array[i - 1]} " | ||
| array[i] = array[i - 1] + array[i] | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end at 18, 6 is not aligned with (1..j).reverse_each do |i| at 12, 2.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| (1..j).reverse_each do |i| | ||
| if(i==j) | ||
| x = " "*z | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end at 15, 6 is not aligned with if at 13, 4.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| (1..depth).each do |j| | ||
| (1..j).reverse_each do |i| | ||
| if(i==j) | ||
| x = " "*z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
Surrounding space missing for operator *.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| array[0] = base_number | ||
| (1..depth).each do |j| | ||
| (1..j).reverse_each do |i| | ||
| if(i==j) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 (not -2) spaces for indentation.
Space after keyword if is missing.
Surrounding space missing for operator ==.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| array[i] = array[i - 1] + array[i] | ||
| end | ||
| z -= 1 | ||
| puts |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab detected.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| print "#{x}#{array[i - 1]} " | ||
| array[i] = array[i - 1] + array[i] | ||
| end | ||
| z -= 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab detected.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| end | ||
| print "#{x}#{array[i - 1]} " | ||
| array[i] = array[i - 1] + array[i] | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab detected.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| x = ' '*z | ||
| end | ||
| print "#{x}#{array[i - 1]} " | ||
| array[i] = array[i - 1] + array[i] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab detected.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| if(i == j) | ||
| x = ' '*z | ||
| end | ||
| print "#{x}#{array[i - 1]} " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab detected.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| (1..j).reverse_each do |i| | ||
| if(i == j) | ||
| x = ' '*z | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab detected.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| (1..depth).each do |j| | ||
| (1..j).reverse_each do |i| | ||
| if(i == j) | ||
| x = ' '*z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab detected.
Use 2 (not 1) spaces for indentation.
Surrounding space missing for operator *.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| array[0] = base_number | ||
| (1..depth).each do |j| | ||
| (1..j).reverse_each do |i| | ||
| if(i == j) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tab detected.
Use 2 (not 1) spaces for indentation.
Space after keyword if is missing.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| z = depth | ||
| array[0] = base_number | ||
| (1..depth).each do |j| | ||
| (1..j).reverse_each do |i| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 (not 1) spaces for indentation.
Tab detected.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| base_number = gets.to_i | ||
| array = [] | ||
| (1..depth).each do |i| | ||
| array[i] = 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use 2 (not 1) spaces for indentation.
Tab detected.
2018/JuliaPrutychenko/1/pascal.rb
Outdated
| end | ||
| print "#{x}#{array[i - 1]} " | ||
| array[i] = array[i - 1] + array[i] | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
end at 18, 3 is not aligned with (1..j).reverse_each do |i| at 12, 2.
Фамилия Имя
Притыченко Юля
Email
juliasnoww@mail.ru
Номер домашнего задания
1
Ссылка на видео с демо работы
https://youtu.be/E55OnnZYuMY
Комментарии
исправленная версия комита