Remove block parameters from input methods#66
Open
nimmolo wants to merge 3 commits intorubymonolith:mainfrom
Open
Remove block parameters from input methods#66nimmolo wants to merge 3 commits intorubymonolith:mainfrom
nimmolo wants to merge 3 commits intorubymonolith:mainfrom
Conversation
Author
|
Noticing that you can pass a block to a |
bradgessler
requested changes
Nov 29, 2025
Contributor
bradgessler
left a comment
bradgessler
left a comment
There was a problem hiding this comment.
The specs can be removed for this and I'll merge.
Reverting spec additions to match main branch. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Author
|
Added specs removed |
Author
|
@bradgessler I think this is good to go, as requested! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: comment here @bradgessler noticed while reviewing another PR of mine that Superform's
inputmethod has an issue with its signature:inputelements are void/self-closing HTML elements and should not accept blocks. This PR removes the&block parameter from:Inputcomponent'sview_templatemethodtext,email,password,hidden,number,date,time,file, etc.)Changes
&fromview_template(&)→view_template&from all 17 input convenience methodsTest Coverage
All 109 tests passing. New tests verify backwards compatibility - blocks can still be passed without errors, but content is correctly ignored.