-
-
Notifications
You must be signed in to change notification settings - Fork 515
Correctly Configure Docker Node Pinning #6712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly Configure Docker Node Pinning #6712
Conversation
8566cca to
38e80b7
Compare
|
@stefannibrasil we had an incorrect docker config. Just wanted to ping you in case you picked up some bad info from working on it earlier |
418ba28 to
f329145
Compare
|
oh, interesting, thanks for the heads up. What error were you getting? |
ff79397 to
c487f59
Compare
d4a3340 to
5ec002f
Compare
|
@FireLemons I see new PRs are broken now, sorry about that! Do you want to maybe revert #6708 and I can take a look? Weird that CI was green when that one was merged. |
5ec002f to
2ab77af
Compare
|
@stefannibrasil I meant that pinning node that way in our Dockerfile is suboptimal and you shouldn't do it in other places like that |
88174cd to
a0899bd
Compare
a0899bd to
7e3c019
Compare
|
Turns out the solution was just to copy the binaries from the node image. I spent a long time tying to copy just the built assets from a build step before remembering the docker image requires node and npm because it's a development environment too. |
Relying on the ruby alpine image for node does not allow us to specify which major version we use. It was the solution for a while because the version of node we wanted just happened to be the same as the node from that image.
Currently we are using an old solution that does allow for custom node version in our image. However the repo we are getting node from is the latest alpine image which has a version of node that updates somewhat frequently which makes the method of pinning in this solution cause a conflict as soon as it updates.