Skip to content

Conversation

@FireLemons
Copy link
Collaborator

What github issue is this PR for, if any?

Resolves #6707

What changed, and why?

The model class CasaCasesEmancipationOption has casa cases in plural which doesn't follow the naming convention of join tables.
The class name was renamed to CasaCaseEmancipationOption

How is this tested? (please write rspec and jest tests!) 💖💪

Tried the migrations locally. Rest of it should be caught by CI.

casa(dev)> CasaCaseEmancipationOption.all
  CasaCaseEmancipationOption Load (0.4ms)  SELECT "casa_case_emancipation_options".* FROM "casa_case_emancipation_options" /* loading for pp */ LIMIT $1  [["LIMIT", 11]]
=> 
[#<CasaCaseEmancipationOption:0x00007fa7f80001c0
  id: 2,
  casa_case_id: 5,
  emancipation_option_id: 13,
  created_at: "2026-02-11 00:51:41.493401000 +0000",
  updated_at: "2026-02-11 00:51:41.493401000 +0000">,
 #<CasaCaseEmancipationOption:0x00007fa7f801d9a0
  id: 3,
  casa_case_id: 5,
  emancipation_option_id: 7,
  created_at: "2026-02-11 00:51:47.890838000 +0000",
  updated_at: "2026-02-11 00:51:47.890838000 +0000">,
 #<CasaCaseEmancipationOption:0x00007fa7f801d860
  id: 4,
  casa_case_id: 5,
  emancipation_option_id: 8,
  created_at: "2026-02-11 00:51:48.419185000 +0000",
  updated_at: "2026-02-11 00:51:48.419185000 +0000">]

@github-actions github-actions bot added ruby Pull requests that update Ruby code Tests! 🎉💖👏 labels Feb 11, 2026
@FireLemons FireLemons changed the title Emancipation option data integrity upgrade CasaCasesEmancipationOption rename to follow naming convention Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ruby Pull requests that update Ruby code Tests! 🎉💖👏

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CasaCasesEmancipationOption does not follow naming convention

1 participant