Improve email visibility and confirmation handling #6666
+4,470
−6,678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev99pedro
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
github-actions
bot
added
dependencies
compwron
reviewed
Feb 13, 2026
| end | ||
| end | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
remove extra line breaks
compwron
reviewed
Feb 13, 2026
| include ByOrganizationScope | ||
| include DateHelper | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
remove extra line breaks
compwron
reviewed
Feb 13, 2026
| <p>Your CASA account's email has been updated to <%= @resource.unconfirmed_email %>.</p> | ||
| <p>We're contacting you to notify you that your email is being changed to <%= @resource.unconfirmed_email %>.</p> | ||
| <% else %> | ||
| <p>Your CASA account's email has been updated to <%= @resource.email %>.</p> |
compwron
reviewed
Feb 13, 2026
| </tr> | ||
| <tr style="font-family: Helvetica,Arial,sans-serif; box-sizing: border-box; font-size: 14px; margin: 0;"> | ||
| <td class="content-block" style="font-family: Helvetica,Arial,sans-serif; box-sizing: border-box; font-size: 14px; vertical-align: top; margin: 0; padding: 0 0 20px;" valign="top"> | ||
| TESTEEEEEE <%=@user.email%>. |
Collaborator
There was a problem hiding this comment.
blocker: remove test text
compwron
reviewed
Feb 13, 2026
| # Show full error reports. | ||
| config.consider_all_requests_local = true | ||
| config.action_mailer.perform_deliveries = true | ||
| config.action_mailer.raise_delivery_errors = true |
compwron
reviewed
Feb 13, 2026
|
|
||
| source "https://rubygems.org" | ||
|
|
||
| group :development do |
Collaborator
There was a problem hiding this comment.
valid and correct to put letter_opener in a devlopment gem section
compwron
reviewed
Feb 13, 2026
| ruby "3.3.8" | ||
| gem "rails", "~> 7.2" | ||
|
|
||
| gem "paper_trail" |
Collaborator
There was a problem hiding this comment.
paper_trail is useful but what is it doing here
compwron
requested changes
Feb 13, 2026
Collaborator
compwron
left a comment
compwron
left a comment
There was a problem hiding this comment.
Please resolve outstanding comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Resolves #6626
What changed, and why?
How is this tested? (please write rspec and jest tests!) 💖💪
Note: if you see a flake in your test build in github actions, please post in slack #casa "Flaky test: " :) 💪
Note: We love capybara tests! If you are writing both haml/js and ruby, please try to test your work with tests at every level including system tests like https://github.com/rubyforgood/casa/tree/main/spec/system
Screenshots please :)
Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.
Feelings gif (optional)
What gif best describes your feeling working on this issue? https://giphy.com/
How to embed:
