Add workshops dropdown filter to workshop_logs index #729
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
Enable filtering workshop logs by workshop without degrading page performance. The original attempt used
Workshop.joins(:workshop_logs)which joined all workshop logs regardless of user permissions or active filters, causing slow queries.How did you approach the change?
Changed query strategy from JOIN to subquery:
This approach:
reports.workshop_id@workshop_logs_unpaginatedView changes:
Test coverage:
Anything else to add?
The WorkshopLog model already had the
workshop_idscope and search method support, so only the controller query and view needed changes. No migrations or new dependencies required.Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.