Complete ActionPolicy implementation for Resource model #717
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add authorization checks to all controller actions (new, search) - Add missing policy rules (create?, search?, stories?) - Write comprehensive policy tests covering all rules and scopes - Add ActionPolicy RSpec support - Verify Draper decorator integration is working Co-authored-by: maebeale <7607813+maebeale@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add ActionPolicy gem and apply it to resources
Complete ActionPolicy implementation for Resource model
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
ActionPolicy gem was added but incompletely applied to the Resource model. Missing authorization checks on controller actions and incomplete policy rules created potential security gaps.
How did you approach the change?
Controller Authorization
authorize!tonewandsearchactions (previously missing)Policy Rules
create?,search?,stories?rulescreate?/search? → new?,stories? → index?Draper Integration
ActionPolicy::Drapermodule inlib/action_policy/draper.rbunwraps decorators before policy checksTesting
spec/support/action_policy.rbAnything else to add?
Views already use
allowed_to?helper correctly. ApplicationController has proper error handling viarescue_from ActionPolicy::Unauthorized.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.