Skip to content

Add quote and image icons to workshop log displays#1420

Open
maebeale wants to merge 1 commit intomainfrom
maebeale/log-quote-image-icons
Open

Add quote and image icons to workshop log displays#1420
maebeale wants to merge 1 commit intomainfrom
maebeale/log-quote-image-icons

Conversation

@maebeale
Copy link
Collaborator

What is the goal of this PR and why is this important?

  • Show at a glance which workshop logs have quotes or images attached
  • Uses hollow teal Font Awesome icons (fa-regular fa-comment and fa-regular fa-image) consistent with the workshop log color theme

How did you approach the change?

  • Added has_quotes? and has_gallery_images? methods to WorkshopLog
  • Created a shared _content_icons partial rendered on all workshop log display views:
    • Person show cards (_workshop_log_card)
    • Date rows in grouped cards and standalone page (_workshop_log_date_row)
    • Admin index table (_index)
  • Eager-loaded :quotable_item_quotes and :gallery_assets in controllers to avoid N+1 queries

UI Testing Checklist

  • Person show page — workshop log cards show icons when log has quotes/images
  • Person workshop logs standalone page — date rows show icons
  • Workshop logs index (admin table) — date column shows icons

Anything else to add?

  • Icons only render when a log actually has content, so logs without quotes/images are unchanged

🤖 Generated with Claude Code

Show hollow teal Font Awesome icons (comment, image) on workshop log
cards, date rows, and index table when a log has quotes or gallery
images. Eager-load associations to avoid N+1 queries.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant