-
-
Notifications
You must be signed in to change notification settings - Fork 231
ci: add rails 7.2 and 8.0 to the test matrix and bump some older dependencies #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
8c4bbb1
ci: add rails 7.2 and 8.0 to the test matrix and bump some older depe…
pkuczynski e50761d
Merge branch 'master' into ci/newer-rails
pkuczynski f01aea9
update
pkuczynski bbefd72
Merge branch 'master' into ci/newer-rails
pkuczynski fe5ba4f
update
pkuczynski 7ec9827
would this work
pkuczynski 3dbfdeb
rails 8 needs newer ruby
pkuczynski e0e611d
syntax
pkuczynski 9718fd1
should work without gemfiles
pkuczynski 8e6dec8
downgrade sqlite
pkuczynski 0346c87
fix java
pkuczynski e2a731e
min ruby
pkuczynski 6b5e3c0
try now
pkuczynski ed4999f
minor updates
pkuczynski 673b220
exclude rails 8 from jruby
pkuczynski 12032b8
ci: fix ci for new rails (#375)
Nuzair46 bdf2df9
try
pkuczynski ed47f7a
Merge remote-tracking branch 'origin/ci/newer-rails' into ci/newer-rails
pkuczynski d2a22cd
skip jruby for rails >= 7.1
pkuczynski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| .idea | ||
| .bundle | ||
| gemfiles/*.lock | ||
| gemfiles/bin | ||
| gemfiles | ||
| log | ||
| pkg | ||
| spec/app/**/db/*.sqlite* | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,48 @@ | ||
| # See https://docs.docker.com/engine/reference/builder/#dockerignore-file for more about ignoring files. | ||
|
|
||
| # Ignore git directory. | ||
| /.git/ | ||
| /.gitignore | ||
|
|
||
| # Ignore bundler config. | ||
| /.bundle | ||
|
|
||
| # Ignore all environment files (except templates). | ||
| /.env* | ||
| !/.env*.erb | ||
|
|
||
| # Ignore all default key files. | ||
| /config/master.key | ||
| /config/credentials/*.key | ||
|
|
||
| # Ignore all logfiles and tempfiles. | ||
| /log/* | ||
| /tmp/* | ||
| !/log/.keep | ||
| !/tmp/.keep | ||
|
|
||
| # Ignore pidfiles, but keep the directory. | ||
| /tmp/pids/* | ||
| !/tmp/pids/.keep | ||
|
|
||
| # Ignore storage (uploaded files in development and any SQLite databases). | ||
| /storage/* | ||
| !/storage/.keep | ||
| /tmp/storage/* | ||
| !/tmp/storage/.keep | ||
|
|
||
| # Ignore assets. | ||
| /node_modules/ | ||
| /app/assets/builds/* | ||
| !/app/assets/builds/.keep | ||
| /public/assets | ||
|
|
||
| # Ignore CI service files. | ||
| /.github | ||
|
|
||
| # Ignore development files | ||
| /.devcontainer | ||
|
|
||
| # Ignore Docker-related files | ||
| /.dockerignore | ||
| /Dockerfile* |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| # See https://git-scm.com/docs/gitattributes for more about git attribute files. | ||
|
|
||
| # Mark the database schema as having been generated. | ||
| db/schema.rb linguist-generated | ||
|
|
||
| # Mark any vendored files as having been vendored. | ||
| vendor/* linguist-vendored | ||
| config/credentials/*.yml.enc diff=rails_credentials | ||
| config/credentials.yml.enc diff=rails_credentials |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| version: 2 | ||
| updates: | ||
| - package-ecosystem: bundler | ||
| directory: "/" | ||
| schedule: | ||
| interval: daily | ||
| open-pull-requests-limit: 10 | ||
| - package-ecosystem: github-actions | ||
| directory: "/" | ||
| schedule: | ||
| interval: daily | ||
| open-pull-requests-limit: 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,90 @@ | ||
| name: CI | ||
|
|
||
| on: | ||
| pull_request: | ||
| push: | ||
| branches: [ main ] | ||
|
|
||
| jobs: | ||
| scan_ruby: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: .ruby-version | ||
| bundler-cache: true | ||
|
|
||
| - name: Scan for common Rails security vulnerabilities using static analysis | ||
| run: bin/brakeman --no-pager | ||
|
|
||
| scan_js: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: .ruby-version | ||
| bundler-cache: true | ||
|
|
||
| - name: Scan for security vulnerabilities in JavaScript dependencies | ||
| run: bin/importmap audit | ||
|
|
||
| lint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: .ruby-version | ||
| bundler-cache: true | ||
|
|
||
| - name: Lint code for consistent style | ||
| run: bin/rubocop -f github | ||
|
|
||
| test: | ||
| runs-on: ubuntu-latest | ||
|
|
||
| # services: | ||
| # redis: | ||
| # image: redis | ||
| # ports: | ||
| # - 6379:6379 | ||
| # options: --health-cmd "redis-cli ping" --health-interval 10s --health-timeout 5s --health-retries 5 | ||
| steps: | ||
| - name: Install packages | ||
| run: sudo apt-get update && sudo apt-get install --no-install-recommends -y google-chrome-stable curl libjemalloc2 libvips sqlite3 | ||
|
|
||
| - name: Checkout code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Set up Ruby | ||
| uses: ruby/setup-ruby@v1 | ||
| with: | ||
| ruby-version: .ruby-version | ||
| bundler-cache: true | ||
|
|
||
| - name: Run tests | ||
| env: | ||
| RAILS_ENV: test | ||
| # REDIS_URL: redis://localhost:6379/0 | ||
| run: bin/rails db:test:prepare test test:system | ||
|
|
||
| - name: Keep screenshots from failed system tests | ||
| uses: actions/upload-artifact@v4 | ||
| if: failure() | ||
| with: | ||
| name: screenshots | ||
| path: ${{ github.workspace }}/tmp/screenshots | ||
| if-no-files-found: ignore |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this a good idea to ignore the whole gemfiles folder? should be just lockfiles only right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a good question, but since all those files are anyway auto generated by
appraisal installI think it does not really make sense to keep it in the repo?