Skip to content

Fix issues and hide token #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dhananjaysathe wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix issues and hide token #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f022424
Add redirect get rid of ticket , fix the parameter deletion as this i…
dhananjaysathe Oct 23, 2013
59f9fc8
Hotfix
dhananjaysathe Oct 24, 2013
bd4fa28
Get extra attributes
dhananjaysathe Dec 6, 2013
c1f4700
show more data in test app
dhananjaysathe Dec 6, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/cas_example.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,6 @@ class CasExample < Sinatra::Base
get "/protected" do
require_authorization(request, session) unless logged_in?(request, session)

"you are logged in as #{session[:cas_user]}"
"you are logged in as #{session}"
end
end
8 changes: 5 additions & 3 deletions lib/cas_helpers.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ def process_cas_login(request, session)
if st.success
session[:cas_ticket] = st.ticket
session[:cas_user] = st.user
session[:cas_extra_attributes] = st.extra_attributes
return service_url
else
raise "Service Ticket validation failed! #{st.failure_code} - #{st.failure_message}"
end
Expand Down Expand Up @@ -62,9 +64,9 @@ def read_service_url(request)
service_url = url(request.path_info)
if request.GET
params = request.GET.dup
params.delete(:ticket)
if params
[service_url, Rack::Utils.build_nested_query(params)].join('?')
params.delete("ticket")
unless params.empty?
return [service_url, Rack::Utils.build_nested_query(params)].join('?')
end
end
return service_url
Expand Down