Add --color tag so we can remove color from output, refactor output formatting #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivy
approved these changes
Jan 7, 2026
Template expansion was scattered between checkers and formatters, making
it difficult to maintain consistency between default and user-supplied
templates. The reference_location placeholder needed special handling
per output format.
Changes:
- Add template.rs with expand(), build_violation_vars(), and helpers
- Move all template expansion from pack_checker to formatters
- Violation struct now stores data only (no pre-expanded message)
- ViolationIdentifier.violation_type is now CheckerType enum
- Each formatter handles reference_location appropriately:
- text: colorized or plain based on color mode
- json: cleared (location in separate fields)
- csv: plain format
- Default templates restored to include {{reference_location}}
martinemde
force-pushed
the
martinemde/text-formatting
branch
from
58760e2 to
82d25f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.