Capture stdout from Packwerk CLI #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
force-pushed
the
martinemde/capture-stdout
branch
2 times, most recently
from
87c862c to
689058a
Compare
Also use the default Plain style.
martinemde
force-pushed
the
martinemde/capture-stdout
branch
from
689058a to
ac8f747
Compare
dduugg
approved these changes
Dec 19, 2025
This seems to be from a time when the CLI would exit. We don't use the CLI in a way where this can happen anymore.
martinemde
force-pushed
the
martinemde/capture-stdout
branch
from
ac8f747 to
218860e
Compare
dduugg
approved these changes
Dec 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also use the default Plain style.
There's no reason to print this output when we're redirecting the output to danger.
I chose to leave
out_errunset in case it suppresses warning or makes it harder to diagnose issues.This also includes a small fix I noticed when looking at the Packwerk code. It never calls
exitwithin the method that we're calling, so this rescue would never trigger.