Add enforcement_globs_ignore behavior to skip comments #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
force-pushed
the
martinemde/enforcement_globs_ignore
branch
from
16bf42d to
945a78d
Compare
Contributor
Author
|
I would be fine merging this. Although it doesn't support the full behavior, it gets half of it (privacy). |
perryqh
approved these changes
May 14, 2025
martinemde
force-pushed
the
martinemde/enforcement_globs_ignore
branch
from
945a78d to
a27a847
Compare
Contributor
Author
|
Current status. Incomplete, needs to be updated for the improved tests. When working on this, it became clear that the test mocks were not adequate to properly test this behavior and we haven't had time to revisit this feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pkssupports a config key namedenforcement_globs_ignorewhich prevents violations from being reported when they otherwise would be. Since this library usespackwerkto generate violations, it doesn't have that feature. This is an attempt to patch this feature into danger-packwerk.