Generate links in formatter using head ref #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
force-pushed
the
ie-me-aw/repo-link-builder
branch
from
aa58911 to
f2796f5
Compare
martinemde
changed the title
The change is backwards compatible, but sorbet forces everyone to update their method signature anyway.
tstannard
reviewed
Mar 24, 2025
tstannard
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds on a repo_link_builder argument to the OffenseFormatter in order to supply the formatter with the ability to create a repo link consistently.
This also changes the formatter links to use the HEAD of the branch instead of main, which is not available on every repository.
This is an alternate implementation of #53.
Our goal in the alternate implementation was to avoid passing the entire
selfto the formatter. We thought that the html_link including anchor tags wasn't great, so we settled on a version that still constructs the url manually, but uses more information and allows for us to extend this in the future.