Skip to content

Conversation

@perryqh
Copy link
Contributor

@perryqh perryqh commented Dec 3, 2025

What problem is this solving?

The current error message — CODEOWNERS out of date. Run 'codeowners generate' to update the CODEOWNERS file — assumes the executable is named codeowners. However, this isn’t always true, such as when using codeowners-rs via the code_ownership
gem.

To prevent confusion for end users, this change introduces a new executable_name configuration option. It allows projects to specify the actual executable name so the error message accurately reflects the correct command to run.

Other:

  • Bumped the crate version from 0.3.0 to 0.3.1 to reflect the new feature.

@perryqh perryqh force-pushed the ph.executable-name branch from d4378b0 to 3fac3d7 Compare December 3, 2025 20:16
@perryqh perryqh requested a review from martinemde December 3, 2025 20:20
Copy link

@corsonknowles corsonknowles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To my admittedly Ruby-centric eyes, this looks well tested and like it does the thing.

Thanks for designing and shipping the solution here!

Should the PR description be more explicit that this is meant to support wrappers/executables in CI/repos? Add docs?

@perryqh perryqh force-pushed the ph.executable-name branch from d6ad119 to fa33ec1 Compare December 4, 2025 15:11
@perryqh perryqh changed the title Support executable_name in config Support executable_name in config and API Dec 4, 2025
@perryqh perryqh merged commit 68a5e19 into main Dec 17, 2025
8 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Modularity Dec 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants