Fix regression in package.yml metadata.owner key #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinemde
force-pushed
the
push-qoonoyqpvuwm
branch
from
6a7041a to
9baa44e
Compare
martinemde
force-pushed
the
push-qoonoyqpvuwm
branch
from
ca29e4f to
36f1355
Compare
As far as I can tell, this key was not intentionally removed and its presence is missed. Based on issues reported, We're restoring support rather than fix all the other things that depend on it. Tolerate having both keys set as long as they are the same. Fail when metadata.owner and owner are different. Since we don't know what other tooling reads this owner key, it seems better to error on ambiguity. It's possible other tooling reads this value from the package.yml. We can adjust if we find problems. Related to: rubyatscale/code_ownership#141
martinemde
force-pushed
the
push-qoonoyqpvuwm
branch
from
36f1355 to
d829231
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, this key was not intentionally removed and its presence is missed. Based on issues reported, We're restoring support rather than fix all the other things that depend on it.
Related to: rubyatscale/code_ownership#141