Skip to content

Two-phase approach speeds up cold-cache generate #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
martinemde wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Two-phase approach speeds up cold-cache generate #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 17 additions & 2 deletions src/project_builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,11 @@ impl<'a> ProjectBuilder<'a> {
Ok(EntryType::TeamFile(absolute_path.to_owned(), relative_path.to_owned()))
}
_ if matches_globs(&relative_path, &self.config.owned_globs) && !matches_globs(&relative_path, &self.config.unowned_globs) => {
let project_file = self.project_file_builder.build(absolute_path.to_path_buf());
Ok(EntryType::OwnedFile(project_file))
// Defer file processing - just collect the path
Ok(EntryType::OwnedFile(ProjectFile {
path: absolute_path.to_path_buf(),
owner: None, // Will be populated later
}))
}
_ => Ok(EntryType::NullEntry()),
}
Expand Down Expand Up @@ -273,6 +276,18 @@ impl<'a> ProjectBuilder<'a> {
acc
},
);
// Now process all collected files in parallel using rayon
// This is done after file discovery to avoid blocking WalkParallel threads
let project_files: Vec<ProjectFile> = project_files
.into_par_iter()
.map(|mut file| {
// Build the actual project file with owner information
let built_file = self.project_file_builder.build(file.path.clone());
file.owner = built_file.owner;
file
})
.collect();

let teams_by_name = teams
.iter()
.flat_map(|team| vec![(team.name.clone(), team.clone()), (team.github_team.clone(), team.clone())])
Expand Down