-
Notifications
You must be signed in to change notification settings - Fork 3
Refactor runner into façade + modules; extract CODEOWNERS queries; add tests and docs #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR refactors the runner module to improve separation of concerns by splitting the monolithic runner implementation into a façade pattern with dedicated modules. The main goal is to extract domain logic from the public API and improve code organization.
- Creates a modular runner architecture with separate API, types, and core functionality
- Extracts CODEOWNERS query functions into a dedicated module for reusability
- Adds comprehensive test coverage for the new API functions
- Updates documentation with module layout and library usage examples
Reviewed Changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
tests/runner_api.rs |
Comprehensive integration tests for the new runner API functions |
src/runner/types.rs |
Type definitions for RunConfig, RunResult, and Error |
src/runner/api.rs |
Public API functions extracted from the main runner module |
src/runner.rs |
Refactored core runner implementation with simplified public interface |
src/path_utils.rs |
New utility module for path manipulation with tests |
src/ownership/file_owner_resolver.rs |
Updated to use new path utilities |
src/ownership/codeowners_query.rs |
Extracted CODEOWNERS query functions |
src/ownership.rs |
Updated module exports |
src/lib.rs |
Added path_utils module export |
src/crosscheck.rs |
Updated import path |
src/config.rs |
Added Config::load_from_path method |
README.md |
Added module layout documentation and library usage example |
Cargo.toml |
Version bump to 0.2.16 |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a0104c4 to
cf17a65
Compare
cf17a65 to
3eac51c
Compare
Why
What changed