Open
Conversation
Currently, when a user call `URI.regexp`, two messages are shown.
```
$ ruby -w -e "require 'uri'; URI.regexp('https')"
-e:1: warning: URI.regexp is obsolete
uri-1.1.1/lib/uri/common.rb:340: warning: URI::RFC3986_PARSER.make_regexp is obsolete. Use URI::RFC2396_PARSER.make_regexp explicitly.
```
I think this is a bit redundant.
I updated to call `URI::RFC2396_PARSER.make_regexp` directly since
only RFC2396 parser supports `.make_regexp`.
I also updated the message to indicate that `URI::RFC2396.make_regexp` must
be used if you still want to use `URI.regexp`.
This issue also exists in `URI.extract`, so I applied the same fix there.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when a user call
URI.regexp, two messages are shown.I think this is a bit redundant.
I updated to call
URI::RFC2396_PARSER.make_regexpdirectly since only RFC2396 parser supports.make_regexp.I also updated the message to indicate that
URI::RFC2396.make_regexpmust be used if you still want to useURI.regexp.This issue also exists in
URI.extract, so I applied the same fix there.